Re: [PATCH v3 11/12] rtc: rzn1: use FIELD_PREP/FIELD_GET and GENMASK for register access
Wolfram Sang <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-rtc |
|---|---|
| Message-ID | <aoQ_0oAR_MGAAA4K@ninjato> |
On Mon, Jul 06, 2026 at 06:51:37PM +0100, Prabhakar wrote: > From: Lad Prabhakar <[email protected]> > > Replace open-coded shift and mask operations with the bitfield API. > > Note that the weekday field is changed from an explicit 0x0f mask to > an 8-bit field definition, matching the hardware manual. This does not > change behaviour, as valid weekday values cannot exceed 7. > > Signed-off-by: Lad Prabhakar <[email protected]> Not a super big fan of such changes, but OK Reviewed-by: Wolfram Sang <[email protected]>
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmqEP80ACgkQFA3kzBSg Kba36w/+K9qMO/BNax8Y8F60sZ3eHYeHa45rjsSDlyarx26T79qRI95X131sv0rz TI7ULov+l3pxdZDqu9c9cJ4VC+J3SmOGZaVmhg7ADoCIgSeE3uCqRzQjT28upi7e JF+/CoiZc30LSJHYNJf3ox+pBHe+IFdHXsnenMbzGb8WnUnQ/DfD/iPqTZUiLO7X G5udaAwz+cfHz87RHjR/C9mwP+D920UKxEYUPsdDVaQt2izMm5pUG7RMnGLpMufe pYm7B0bvlO8rocY24Ivs7AkpwLFeWj3wWfTzAzMa1mJdWpEscrbekT+mHVjiids8 8BY+ngNmGBNqkbRaVCsONOK8BncgacqMTBOCLyxz09C1xScZxOeTomC3k3wjC/qW uzQb3kruElme2Hwb7BVI72RB2r5BPERDiHpJnS50CG6ps66+C5ErALTIJBvlc0oq nEccroesYcYdlyyKyoHWFy4SvwmSIYuYUhA6WB3WzxivmdKEE0gZ/OLno+9yUL5g +xgupEdmb0Rro7huf6354837khlql+3fhPjXXaknBjJOVcT4ihq50YVe6YYC9nyh T9Y6222l/iS3jzCDuMx20ldFT5yK7jl6mpgNwks3WxmPk0GxyicsPEqeQ8Gko0RD tfIAeFKa/Hs6CICzKQ/jjhoWFJzX+0eSb4ucTuqlHec5lIP5fno= =NR0k -----END PGP SIGNATURE-----