Re: [PATCH v3 2/3] power: sequencing: Add Renesas RZ/G3L Power Ready driver

Geert Uytterhoeven <[email protected]>
Newsgroups org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm
Message-ID <CAMuHMdU2tP-V9H0QthQ8=orDMxXSsLmzv=krkpn7YgYXCR7+Tw@mail.gmail.com>
Hi Biju,

On Wed, 19 Aug 2026 at 10:18, Biju Das <[email protected]> wrote:
> > From: Geert Uytterhoeven <[email protected]>
> > On Wed, 12 Aug 2026 at 13:50, Biju <[email protected]> wrote:
> > > From: Biju Das <[email protected]>
> > >
> > > Add a power sequencing driver for the Renesas RZ/G3L PWRRDY module,
> > > which signals power readiness for various IPs (USB, DSI, CSI etc.) on
> > > the SoC. The driver binds as an auxiliary device to the parent SYSC
> > > driver, using its regmap to toggle the SYS_PWRRDY_N register bits, and
> > > exposes {usb,dsi,csi}-pwrrdy pwrseq targets.
> > >
> > > Signed-off-by: Biju Das <[email protected]>
> >
> > > --- a/drivers/power/sequencing/Kconfig
> > > +++ b/drivers/power/sequencing/Kconfig
> > > @@ -27,6 +27,15 @@ config POWER_SEQUENCING_QCOM_WCN
> > >           this driver is needed for correct power control or else we'd risk not
> > >           respecting the required delays between enabling Bluetooth and WLAN.
> > >
> > > +config POWER_SEQUENCING_RENESAS_PWRRDY
> > > +       tristate "Renesas Power Ready sequencing driver"
> > > +       depends on SYSC_RZ || COMPILE_TEST
> > > +       select AUXILIARY_BUS
> >
> > Could this cause circular dependency problems with ...
>
> You mean this to be fixed as??
>
> depends on SYSC_RZ || (COMPILE_TEST && AUXILIARY_BUS)
>
> So that there won't be any build issue with COMPILE_TEST for
> Auxiliary bus API's

Sorry for being unclear: probably the three exisiting "depends on
AUXILIARY_BUS" should be changed to "select AUXILIARY_BUS".

> > > +       help
> > > +         Say Y here to enable the power sequencing driver for the Renesas
> > > +         Power Ready signals. This driver handles the power ready signals
> > > +         required to power on the various IP's on RZ/G3L platform.
> > > +
> > >  config POWER_SEQUENCING_TH1520_GPU
> > >         tristate "T-HEAD TH1520 GPU power sequencing driver"
> > >         depends on (ARCH_THEAD && AUXILIARY_BUS) || COMPILE_TEST
> >
> > ... e.g. this, due to a mix of (a lot of) selects and (only three) depends?
>
> I believe this should give build error if COMPILE_TEST enabled for this driver
> Without AUXILIARY_BUS enabled??

Possibly, as the auxiliary bus doesn't seem to define dummies in case
AUXILIARY_BUS is not enabled.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.