Re: [PATCH v4 13/15] rtc: rzn1: Add OF match data to gate SUBU register access
Wolfram Sang <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-rtc |
|---|---|
| Message-ID | <aoWr0gfN6sQmgUie@shikoro> |
> + if (!scmp_val && !data->has_subu)
> + return -EOPNOTSUPP;
I'd think here a helpful comment for the user is justified. Maybe "No
valid XTAL provided and SUBU mode not supported"?
> +static const struct rzn1_rtc_data rzn1_data = {
> + .has_subu = true,
> +};
'rzn1_data' is maybe too generic? rzn1_rtc_rzn1_data? Yeah, looks a bit
weird but I personally still like it better.
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmqFq9IACgkQFA3kzBSg KbZhww/+MkTEc0GXAV79EUfSKg5XX/h2Vl3oSR2e6ZrzKyz1YhimDE1/Yb0qycSg kxzTH3TiCeOgT8wCeJk0+5O8PcOqhDa0cNTjMU01N+ivodqtv2ofAfg0XOy+VsQx cAEBpKcfrmbsQdvfLyfSCjJ2hJ+7EGFsdfp3DVwYxtNDeaE2an8AzA8TLs1g04Hf OuBTCPtM9O7ntHGn7QbCh1+s1AeL97WC5/hHalhfiQ35m3lMl5vRtJEK2XKioyEa uwriBMACkAsbhYj3ZoPcwRsSMszBXmmgOh5sFbmg9UNLtXa45p8cGdtcoaUypYGR QBMaS245vaUqEb4hURgD0nJydexcIQbXCoDwrpMEAtRDP+l8G7IcQHnbwg0wGRI/ 9/O9p1Cs06gVG58qEwrTZPpCEcBGJl8QuB0sVtcgqtLtdL9Y+4rwUngiXZwoYBRV asjM3T6+JOtSwfW7why5QU+uEes8iydyARj67sWWE6BpiHqUd8D1NfMP6LeSEHaT Haj9EqPz1DXWWw2WJOdi0lYedT1wiMoMqwgS1CgB3hOR/0p0LDzXASgBWg56tg7X vrftz2ROdcgpfe4ABf1yhxDrDysQIiLcFTC16EnHzXTyz9ETXBwDzyOa3OKnrWQW yrvp8Yvs0vjyfFa7VqnpGURPD9RXA1Hn9m/TTj3RlfpwXgWtsk8= =TyNs -----END PGP SIGNATURE-----