RE: [PATCH 1/2] dt-bindings: sound: renesas,r9a09g047-sound: Drop #clock-cells from required

Tommaso Merciai <[email protected]>
Newsgroups org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound
Message-ID <TYRPR01MB1358899D35FBD843D12ED4F53E0A42@TYRPR01MB13588.jpnprd01.prod.outlook.com>
Hi Geert,
Thanks for your review!

> -----Original Message-----
> From: Geert Uytterhoeven <[email protected]>
> Sent: Thursday, August 20, 2026 12:14 PM
> To: Tommaso Merciai <[email protected]>
> Cc: Tommaso Merciai <[email protected]>; linux-renesas-
> [email protected]; Biju Das <[email protected]>; Liam Girdwood
> <[email protected]>; Mark Brown <[email protected]>; Rob Herring
> <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley
> <[email protected]>; magnus.damm <[email protected]>; Kuninori
> Morimoto <[email protected]>; John Madieu
> <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH 1/2] dt-bindings: sound: renesas,r9a09g047-sound: Drop
> #clock-cells from required
> 
> Hi Tommaso,
> 
> On Thu, 20 Aug 2026 at 11:58, Tommaso Merciai
> <[email protected]> wrote:
> > `#clock-cells` declares the node as a clock provider for AUDIO_CLKOUT,
> > which only makes sense on boards that route that pin.
> >
> > Drop it from the required list so that boards which do not wire
> > AUDIO_CLKOUT can leave it out.
> >
> > Signed-off-by: Tommaso Merciai <[email protected]>
> 
> Thanks for your patch!
> 
> > ---
> > a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> > +++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.
> > +++ yaml
> > @@ -298,7 +298,6 @@ required:
> >    - reg
> >    - reg-names
> >    - "#sound-dai-cells"
> > -  - "#clock-cells"
> >    - clocks
> >    - clock-names
> >    - resets
> 
> I disagree: this is a property of the sound block, not of board wiring.

Maybe better to drop this patch.
Move #clock-cells = <0>; from r9a09g047e57-smarc.dts to r9a09g047.dtsi
Drop clock-frequency = <11289600>; from r9a09g047e57-smarc.dts

What do you think?

Kind regards,
Tommaso

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.