Re: [PATCH 03/12] drm/panic: Return -EINVAL if font is not available
Jocelyn Falempe <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,dev.linux.lists.imx,dev.linux.lists.sashiko-reviews,dev.linux.lists.virtualization,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.freedesktop.lists.intel-xe,org.freedesktop.lists.nouveau,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-doc,org.kernel.vger.linux-hyperv,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
On 18/08/2026 14:28, Thomas Zimmermann wrote: > Font lookup does not allocate memory. Hence reporting ENOMEM on > failed lookups is misleading. Report EINVAL instead. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe <[email protected]> > > Signed-off-by: Thomas Zimmermann <[email protected]> > --- > drivers/gpu/drm/drm_panic.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c > index 705b72bf0d83..96d238bfceee 100644 > --- a/drivers/gpu/drm/drm_panic.c > +++ b/drivers/gpu/drm/drm_panic.c > @@ -757,8 +757,10 @@ static int _draw_panic_screen_qr_code(struct drm_scanout_buffer *sb) > int qr_width, qr_canvas_width, qr_pitch, v_margin; > u8 *qr_image; > > - if (!font || !stream.workspace) > + if (!stream.workspace) > return -ENOMEM; > + if (!font) > + return -EINVAL; > > r_screen = DRM_RECT_INIT(0, 0, sb->width, sb->height); >