Re: [PATCH 29/45] clk: samsung: Make sure clk_init_data is fully initialized
Geert Uytterhoeven <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,dev.linux.lists.imx,dev.linux.lists.linux-sunxi,dev.linux.lists.soc,org.infradead.lists.linux-mediatek,org.kernel.vger.arm-scmi,org.kernel.vger.linux-clk,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-samsung-soc,org.kernel.vger.linux-tegra,org.ozlabs.lists.linux-aspeed,org.ozlabs.lists.openbmc |
|---|---|
| Message-ID | <CAMuHMdWnXTAVZ_eBfoWNe-sy6BC1X+5EHkDw9R0TAA65Opzi_Q@mail.gmail.com> |
Hi Krzysztof, On Fri, 21 Aug 2026 at 13:04, Krzysztof Kozlowski <[email protected]> wrote: > On 21/08/2026 10:53, Geert Uytterhoeven wrote: > > The clk_init_data structure contains several mutually-exclusive members > > for different methods to specify the possible parents of a clock, > > prompting drivers to initialize only the members they need. However, > > not initializing all members may cause subtle issues, which are only > > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > > enabled. > > > > Make sure all members are fully initialized, to avoid such bugs, and to > > prevent future breakage when converting drivers to a different method > > for specifying the parents. > > > > Signed-off-by: Geert Uytterhoeven <[email protected]> > > Reviewed-by: Krzysztof Kozlowski <[email protected]> Thank you! > Let me know if I should take it via Samsung SoC clock tree. I assume by > default this will go directly via clock tree. In that case, please provide your Acked-by, so the clock maintainers don't have to parse your English response to find out ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds