Re: [PATCH] arm64: dts: renesas: Use hyphens in node names

On 25/08/2026 12:27, Geert Uytterhoeven wrote:
> Hi Krzysztof,
> 
> On Sat, 22 Aug 2026 at 09:58, Krzysztof Kozlowski
> <[email protected]> wrote:
>> DTS coding style encourages to use hyphens instead of underscores in
>> node names. DTC W=2 warns about underscores. Improve existing code
>> because apparently people copy it instead of following DTS coding style
>> for new submissions.
>>
>> Semi-manual validation by checking if no new nodes appeared:
>>
>>   $ for i in dts-old/*/*dtb dts-old/*/*/*dtb; do echo $i; fdtdump ${i} > ${i}.fdt ; fdtdump dts-new/${i#dts-old/} > dts-new/${i#dts-old/}.fdt ; diff -ubB ${i}.fdt dts-new/${i#dts-old/}.fdt ; done | grep -v ' {'
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> 
> Thanks for your patch!
> 
>> --- a/arch/arm64/boot/dts/renesas/gray-hawk-single.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/gray-hawk-single.dtsi
> 
>> @@ -696,7 +696,7 @@ i2c3_pins: i2c3 {
>>                 function = "i2c3";
>>         };
>>
>> -       irq0_pins: irq0_pins {
>> +       irq0_pins: irq0-pins {
> 
> This one shouldn't have used a "_pins" suffix in the first place.
> I will sneak in that change while applying ;-)

I see other nodes indeed lack it, but usually bindings expect suffix for
pincfg/pinmux.


Best regards,
Krzysztof