Re: [PATCH 3/4] i2c: riic: Drop the space in front of the "out" goto label

Geert Uytterhoeven <[email protected]>
Newsgroups org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-i2c,org.kernel.vger.linux-kernel
Message-ID <CAMuHMdUtGizx1R05Q9rdV7TDoqSP_ydN=k032uDN1QuHETxBYQ@mail.gmail.com>
Hi Wolfram,

On Thu, 28 May 2026 at 16:10, Wolfram Sang <[email protected]> wrote:
> On Wed, May 20, 2026 at 04:12:05PM +0300, Claudiu Beznea wrote:
> > From: Claudiu Beznea <[email protected]>
> >
> > Drop the space in front of the "out" goto label from riic_xfer() to follow
> > the pattern used in tree.
>
> Time for this quote again :)
>
> > > "> It is generally accepted to indent labels with a single space. This
> > >  > avoids breaking the -p option of diff."
>
> And yeah, I have been bitten by that.

Looks like "git diff" improved upon that ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.