Re: [PATCH v3 8/8] arm64: dts: renesas: rzg3s-smarc: Enable CAN-FD
Geert Uytterhoeven <[email protected]>
| Newsgroups | org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-can,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAMuHMdWYyGci_NNG8u+erL+vGeL+8vUXBsZ+1gcaBq-QYFWV2g@mail.gmail.com> |
Hi Claudiu, On Tue, 14 Jul 2026 at 19:34, Claudiu Beznea <[email protected]> wrote: > From: Claudiu Beznea <[email protected]> > > The two CAN FD channels available on the Renesas RZ/G3S SoC are routed > through the Renesas SMARC Carrier II board when used with the Renesas > RZ/G3S SMARC Module. > > The CAN transceiver on the Carrier II board has its standby pins connected > to GPIOs that are selected through the SW_GPIO_CAN_PMOD switches. By > default, these switches route the GPIOs to the PMOD interfaces. > > Enable the CAN FD controller and its two available channels. > > Reviewed-by: Biju Das <[email protected]> > Signed-off-by: Claudiu Beznea <[email protected]> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <[email protected]> > --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi > +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi > @@ -68,6 +68,24 @@ codec_dai: simple-audio-card,codec { > }; > }; > > + can_transceiver0: can-phy0 { > + compatible = "ti,tcan1042"; > + #phy-cells = <0>; > + max-bitrate = <8000000>; > +#if SW_GPIO_CAN_PMOD1 == SW_OFF > + standby-gpios = <&pinctrl RZG2L_GPIO(13, 0) GPIO_ACTIVE_HIGH>; > +#endif > + }; > + > + can_transceiver1: can-phy1 { > + compatible = "ti,tcan1042"; > + #phy-cells = <0>; > + max-bitrate = <8000000>; > +#if SW_GPIO_CAN_PMOD2 == SW_OFF > + standby-gpios = <&pinctrl RZG2L_GPIO(13, 1) GPIO_ACTIVE_HIGH>; > +#endif > + }; Actually this is a single dual-channel TI TCAN1046V, which is modelled here as two TCAN1042 instances. Recently, we got real support for TCAN1046V, so this should probably be\ rewritten, cfr. "[PATCH/RFT] arm64: dts: renesas: r9a09g047e57-smarc: Update CAN transceivers"[1] (which I wrote a while ago, but never submitted before) > + > vcc_sdhi1: regulator-vcc-sdhi1 { > compatible = "regulator-fixed"; > regulator-name = "SDHI1 Vcc"; [1] https://lore.kernel.org/2a759a486337e4cc8156bc94079471a6552faefc.1787669487.git.geert+renesas@glider.be Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds