Re: [PATCH 4/4] dmaengine: sh: rcar-dmac: Add support for R-Car Gen5 SoCs

On Tue, Aug 25, 2026 at 04:15:46PM +0200, Wolfram Sang wrote:
> Gen5 is very similar to Gen4. Of interest here is that it has a SMMU
> instead of an IPMMU, so we don't need to set the flag for a workaround.

Generally, needn't "we",  simple said

needn't to set ...

Frank

> Make the module description more generic while here.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
>  drivers/dma/sh/rcar-dmac.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> index 9c5210257097..06f691f5f3fb 100644
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -2012,6 +2012,11 @@ static const struct rcar_dmac_of_data rcar_gen4_dmac_data = {
>  	.has_ipmmu = 1,
>  };
>
> +static const struct rcar_dmac_of_data rcar_gen5_dmac_data = {
> +	.chan_offset_base = 0x0,
> +	.chan_offset_stride = 0x1000,
> +};
> +
>  static const struct of_device_id rcar_dmac_of_ids[] = {
>  	{
>  		.compatible = "renesas,rcar-dmac",
> @@ -2019,6 +2024,9 @@ static const struct of_device_id rcar_dmac_of_ids[] = {
>  	}, {
>  		.compatible = "renesas,rcar-gen4-dmac",
>  		.data = &rcar_gen4_dmac_data,
> +	}, {
> +		.compatible = "renesas,rcar-gen5-dmac",
> +		.data = &rcar_gen5_dmac_data,
>  	}, {
>  		/*
>  		 * Backward compatibility for between v5.12 - v5.19
> @@ -2044,6 +2052,6 @@ static struct platform_driver rcar_dmac_driver = {
>
>  module_platform_driver(rcar_dmac_driver);
>
> -MODULE_DESCRIPTION("R-Car Gen2 DMA Controller Driver");
> +MODULE_DESCRIPTION("R-Car DMA Controller Driver");
>  MODULE_AUTHOR("Laurent Pinchart <[email protected]>");
>  MODULE_LICENSE("GPL v2");
> --
> 2.47.3
>