Re: [PATCH] rteval: Updated parameter names
John Kacur <[email protected]>
| Newsgroups | org.kernel.vger.linux-rt-users |
|---|---|
| Message-ID | <[email protected]> |
Hi Sana, Thanks for the patch! I've tested it and it works correctly: ``` rteval --onlyload -D -d 1 --stressng-stressor cpu --stressng-workers 1 [DEBUG] [stressng] starting with stress-ng --cpu 1 --taskset 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15 ``` The code changes look good and I'll apply this patch. However, the commit message could be more descriptive. Instead of just saying "to promote clarity", it would help reviewers to explain: 1. **What problem does this solve?** (the old names were ambiguous/generic) 2. **Why are the new names better?** (they clearly indicate purpose) 3. **What's the user-visible impact?** (command-line option changes) For example: ``` rteval: Rename stress-ng module parameters for clarity The stress-ng module used generic parameter names "option" and "arg" which were ambiguous and didn't clearly indicate their purpose. Rename for better clarity: - "option" → "stressor": Better reflects that this specifies which stress-ng stressor to run (cpu, vm, etc.) - "arg" → "workers": More accurately describes the parameter as the number of worker processes (default: 0 = one per CPU) This changes the command-line options: --stressng-option → --stressng-stressor --stressng-arg → --stressng-workers Update unit tests to reflect the new parameter names. ``` Good commit messages help future maintainers understand the reasoning behind changes. Thanks again for the patch! Signed-off-by: John Kacur <[email protected]>