Re: [PATCH 06/23] mcp-server: Add plugin.json configuration
Tomas Glozar <[email protected]>
| Newsgroups | org.kernel.vger.linux-rt-users |
|---|---|
| Message-ID | <CAP4=nvSnJZE9cis_zAvhrPssih5ev66B4897HBoqntdJQj6PLA@mail.gmail.com> |
Hi John, po 17. 8. 2026 v 22:59 odesílatel John Kacur <[email protected]> napsal: > > Hi Tomas, > > On Mon, 17 Aug 2026 10:04:49 +0200, Tomas Glozar wrote: > > I certainly don't have "/home/jkacur" on my system. This looks like a > > leftover artifact from a Claude debugging session. > > You're right that the absolute path won't work on other systems. The path > shown here is for running the MCP server directly from git during > development, but it's specific to my checkout location. > > This is fixed later in the series: > > Patch 22/23 (002445fe017d "mcp-server: Restructure as Python package > with dynamic paths") restructures the code as a proper Python package > and introduces a wrapper script that dynamically calculates paths based > on its own location. > Ah, I see. Sorry for the noise. > Patch 23/23 (c16aa3b26492 "mcp-server: Use relative path in .mcp.json > and add example for installation") then updates .mcp.json to use a > relative path: > > ./rteval_mcp/rteval-mcp-server > > This allows the MCP server to run from any git checkout location without > requiring modification, and the wrapper script handles both development > (git checkout) and system installation scenarios. > > Thanks for reviewing! > > John > You might want to consider cleaning up patchsets to exclude development artifacts like this, so that reviewer's work is easier. In this case for example, you add an MCP server, then restructure it in the same patchset. The reviewer would ideally only review the final result. Tomas