Re: [PATCH v4] rtc: abx80x: Don't warn about oscillator failure after POR

> From: Sean Anderson <[email protected]>
>=20
> According to the datasheet, the "oscillator failure" bit is set
>=20
>   ...on a power on reset, when both the system and battery voltages have
>   dropped below acceptable levels. It is also set if an Oscillator Failure
>   occurs....
>=20
> From testing, this bit is also set if a software reset is initiated.
>=20
> This bit has a confusing name; it really tells us whether the time data
> is valid. We clear it when writing the time. If it is still set, that
> means there is a persistent issue, such as an oscillator failure,
> instead of a transient one, such as power loss.
>=20
> Because there are several other reasons which might cause this bit to be
> set, including booting for the first time or a battery failure, do not
> warn about oscillator failures unconditionally. This may cause system
> integrators to waste time investigating the wrong issue.
>=20
> Continue printing a message about invalid time data before the time has
> been set. Only report an oscillator failure after the driver has
> successfully written the time and cleared the flag.
>=20
> Signed-off-by: Sean Anderson <[email protected]>
> Signed-off-by: Fabio Estevam <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260725002320.9666=
[email protected]?part=3D1