Re: [PATCH v4 13/15] rtc: rzn1: Add OF match data to gate SUBU register access
Wolfram Sang <[email protected]>
| Newsgroups | org.kernel.vger.linux-rtc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-renesas-soc |
|---|---|
| Message-ID | <aogbk-moFmTTFkJ0@shikoro> |
> } else if (!data->has_subu) {
> return dev_err_probe(dev, -EOPNOTSUPP,
> "No valid XTAL provided and SUBU mode not
Yeah, looks good to me. It is maybe a bit hidden that xtal == NULL in
the above case. I wonder if adding a comment above the return command
/* xtal is NULL here */
will help understanding? But I'll leave it to you.
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmqIG48ACgkQFA3kzBSg KbY/zg/+Of59Tl+ksOh1ZjWKKHkcpR6EXcG0zxzOYsXFZ8cakdLFXeoLNV21EaGW cbxZETOsPY+pbEpvG5/bwmv+nI/xI2FEH8RpXbkLjIQZxR8SvqHU3l/7zoPn+1vv qXsl/vecQm2rL54bJnyiZ8h+pGnlJR7D0Ix0baajH9LGcV5TCH4R+hsSu4aDjhjE nVKmu1txp+zuUhjlzVzWonD/H/CeMxRO9BJx6Jy+bLc4XNJvp6cMHCF4qOrPjshw UbUJNH/6UVB6mOjg4CFPysiZzoXZb+iJ5Uhj5ns1UqIp66InIAEUM5CLdbhaZTqK jhUoKSKnywtBSc+N7Act5mCCvUPjke41253G+VtV5ogwfpVT2Vx9nN1EgI7VNhRU rCnshqJvppU0RRT1WlQBH0kRL/5yVY9d/YG9YjVoiQ+i3xIK+EkWCrxMJjMimj1G 8hXy3E9OEV4R/VZmqhYV1LNro8fozptm77xOGkKa+p4AMOUpLiL2eenTcb7hA++Z p/wZi8NXPnsXHDbR3A1sxmxlrzOIMf5khDs0suACLo3WcUJMq/fFCdTEPRHTXwuH KrWm9H/fBl2SCBLWzOGic4fC11O+Z2dU+wo9hiGaJupeXyQofwR2nDGq3rW6a5Nd UY22bstARtMdWYCybjPB37gKSqoWosjhWvm2BULfNlbjJhhxxN8= =Eu7r -----END PGP SIGNATURE-----