Re: [PATCH v4 13/15] rtc: rzn1: Add OF match data to gate SUBU register access

"Lad, Prabhakar" <[email protected]> Fri, 21 Aug 2026 12:06:00 +0100

Newsgroups	org.kernel.vger.linux-rtc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-renesas-soc
Message-ID	<CA+V-a8txC5U_VvXBYnMXctBg2Jz3a44NZjn-P39amUq5HihG+A@mail.gmail.com>

Hi Wolfram,

On Fri, Aug 21, 2026 at 10:34 AM Wolfram Sang
<[email protected]> wrote:
>
>
> > } else if (!data->has_subu) {
> >         return dev_err_probe(dev, -EOPNOTSUPP,
> >                              "No valid XTAL provided and SUBU mode not
>
> Yeah, looks good to me. It is maybe a bit hidden that xtal == NULL in
> the above case. I wonder if adding a comment above the return command
>
>         /* xtal is NULL here */
>
> will help understanding? But I'll leave it to you.
>
Sure, I will add a comment.

Cheers,
Prabhakar