Re: [PATCH v5 06/17] rtc: rzn1: Disable alarm interrupt before reprogramming alarm registers
Wolfram Sang <[email protected]>
| Newsgroups | org.kernel.vger.linux-rtc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-renesas-soc,org.kernel.vger.stable |
|---|---|
| Message-ID | <aohqhMZ2nhJObwnz@ninjato> |
On Fri, Aug 21, 2026 at 02:55:57PM +0100, Prabhakar wrote: > From: Lad Prabhakar <[email protected]> > > rzn1_rtc_set_alarm() updates RZN1_RTC_ALM, RZN1_RTC_ALH and > RZN1_RTC_ALW using separate MMIO writes without first disabling the > alarm interrupt. If a previous alarm is still enabled, the interrupt > can fire while the alarm registers contain a mixture of old and newly > written values. > > Fix this by disabling the alarm interrupt before reprogramming ALM, ALH > and ALW with a call to rzn1_rtc_alarm_irq_enable(). > > Fixes: b5ad1bf00d2c4 ("rtc: rzn1: Add alarm support") > Cc: [email protected] > Signed-off-by: Lad Prabhakar <[email protected]> Reviewed-by: Wolfram Sang <[email protected]> Tested-by: Wolfram Sang <[email protected]>
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmqIaoQACgkQFA3kzBSg KbZ5wg//W9uPmECk315BxyjWnIHrFTKRLybDiHtyVUOQ3zSuIyRhBGBvlZE3Kj/I IZ3+VHx9ieAps9NGlTrES8NCL6bHkNwFZQ4KhQXdwWk1sCQnZTXCuofZyU0h5Ojf VUwiaSHFO9dDmbOdJ9NfXMnzUJOw8bpdY3zvUQwOOIR42m3S0pXCrRYS9ywj8IMM zPXogefpi3x8fwC9rtvs/eyNOL7Y4y2LlIweSuQC8/nziMH4jCM0wXktc4xRcJqo qqHcfdwkUmaIvcAok50Z7uNBU/8N/h9b9dMe0dqILEk/WqqTIq/dyvWl9lowlvD4 98af32FLGWaKaoj7VTDZ7wnRj3YPtVRucffNUrfsn8TGUE1h0FxiU55GXtX44ZbQ BPLyAIE7xdmYKMKCy0DDoSJRiCpztR/L9MQxhJyPXBJqVtTRGhTt62Te7ZeuhYf2 OFOKnbsRJBGP6G1EOJRQSCv5i9gVIWiSetGL4lduiNOUOohF5PFp6cOgeVQk9pnT SHAgIvx7KQ/WdmZ23LfUlJerMJmQf4kLnpAd5jVPjYRrZeEgOjBOKd9JXxdlfgn7 8ZYEPm4FlrmrlfN1f3pRkPcECP8RKdAYyKvOj5D0KwFM1UWHYYdp5wVv7u/iAmqs 2PR67W5O7+B54b8dPvOtYleUnuYxNp/XNWSVXQm1IzyKesNp+Jw= =MMen -----END PGP SIGNATURE-----