Re: [PATCH] rtc: pm8xxx: do not fail probe when UEFI offset variable is missing

> On machines using "qcom,uefi-rtc-info" the Unix epoch offset for the
> read-only PMIC RTC counter lives in the RTCInfo UEFI variable. The
> driver reads it at probe time and treats every failure as fatal,
> including EFI_NOT_FOUND.
> 
> That turns a merely-uninitialized clock into a permanently absent one
> on firmware that never creates the variable. The ASUS Zenbook A16
> (UX3607OA, Snapdragon X2 Elite Extreme "Glymur", InsydeH2O UEFI) is
> such a machine: qseecom and uefisecapp come up fine, other variables
> in the same Qualcomm vendor GUID (882f8c2b-9646-435f-8de5-f208ff80c1bd)
> exist and are readable, but among the 110 variables exposed through
> efivarfs there is no RTCInfo -- and Windows on the same machine does
> not create one either. Probe then fails:
> 
>   rtc-pm8xxx c426000.spmi:pmic@0:rtc@6100: probe with driver rtc-pm8xxx
> [ ... ]
> following boot restores correct wall time from the RTC before any
> network is up.
> 
> Fixes: bba38b874886 ("rtc: pm8xxx: add support for uefi offset")
> Signed-off-by: Greg Ociepka <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1