Re: [PATCH v3 1/4] s390/crypto: Replace cond_resched() with msleep(1)

Heiko Carstens <[email protected]>
Newsgroups org.kernel.vger.linux-s390,org.kernel.vger.linux-crypto,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Fri, Jul 31, 2026 at 10:40:27AM +0200, Peter Zijlstra wrote:
> On Fri, Jul 31, 2026 at 09:44:57AM +0200, Holger Dengler wrote:
> 
> > > Yes, guest migration is very likely far more disruptive than most
> > > anything else. Perhaps clarify the code comment to include some of this
> > > explanation?
> > 
> > I agree, the comment is not telling all main key points. What about the
> > following?
> > 
> > /*
> >  * Protected key expired due to relocation to another
> >  * host. The long runnning re-wrap has no asynchronous
> >  * completion notification, so polling is required.
> >  * Trigger a re-schedule of this request by returning
> >  * -ENOSPC ("hardware queue full") to the crypto engine.
> >  * To avoid immediately re-invocation of this callback,
> >  * tell scheduler to voluntarily give up the CPU here.
> >  */
> > 
> > (I would leave it up to Heiko to merge the comment in his series, or let
> > Harald/me do it in a separate patch)
> 
> Right, perhaps something like so, avoiding the endless copy/paste ?

I guess there won't be any disagreement. I'll merge your patch, and
add Holger's explanation to the commit message.

Thanks!
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.