Re: [PATCH v4 1/4] s390/crypto: Replace cond_resched() with msleep(1)

> From: Peter Zijlstra <[email protected]>
> 
> With [1] cond_resched() is always compiled away and becomes a no-op.
> 
> The comments for all cond_resched() calls in crypto code however indicate
> that the current process should be scheduled away to avoid instant
> re-invocation of a callback. This is not what cond_resched() would do or
> did.
> 
> Instead of just removing the cond_resched() calls, replace them with
> msleep() calls, as suggested by Holger Dengler. This forces the current
> task to be scheduled away (sleeps) like originally intended.
> 
> Holger provided information why this intended [2]:
> "
> [ ... ]
> 
> [[email protected]: took Peter's patch [3] and provided commit message]
> 
> Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
> Signed-off-by: Heiko Carstens <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1