Re: [PATCH v6 01/18] s390/dasd: Do not complete a failed ESE read as successful
[email protected] Sat, 01 Aug 2026 11:27:24 +0000
| Newsgroups | org.kernel.vger.linux-s390 |
|---|---|
| Message-ID | <[email protected]> |
> dasd_int_handler() completes an NRF read of an unallocated ESE track by
> calling ese_read() and unconditionally marking the request
> DASD_CQR_SUCCESS. dasd_eckd_ese_read() can return an error before it has
> zeroed the destination buffer: a failed sense-data parse or a current
> track outside the requested range both return early, leaving the
> destination pages untouched. The request is still completed successfully,
> so the block layer is handed stale / uninitialized memory instead of
> zeros.
>
> Check the ese_read() return value and fail the request through the normal
> error path instead of forcing DASD_CQR_SUCCESS.
>
> Fixes: 5e6bdd37c552 ("s390/dasd: fix data corruption for thin provisioned devices")
> Cc: [email protected]
> Signed-off-by: Stefan Haberland <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1