Re: [PATCH 1/3] s390/pci: Rework __zpci_event_error() to remove conditional locking

> Clang's compiler based static context analysis does not work with
> locks that are conditionally taken like in __zpci_event_error():
> 
> arch/s390/pci/pci_event.c:320:2: warning: mutex 'get_zdev_by_fid(ccdf->fid).state_lock'
>  is not held on every path through here [-Wthread-safety-analysis]
> 
> Given that code which takes locks conditionally can be considered
> suboptimal rework __zpci_event_error() to get rid of this.
> 
> Signed-off-by: Heiko Carstens <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1