Re: [PATCH v2 1/3] s390/pci: Rework __zpci_event_error() to remove conditional locking

[email protected] Mon, 03 Aug 2026 14:36:05 +0000
Newsgroups org.kernel.vger.linux-s390
Message-ID <[email protected]>
> Clang's compiler based static context analysis does not work with
> locks that are conditionally taken like in __zpci_event_error():
>=20
> arch/s390/pci/pci_event.c:320:2: warning: mutex 'get_zdev_by_fid(ccdf->fi=
d).state_lock'
>  is not held on every path through here [-Wthread-safety-analysis]
>=20
> Given that code which takes locks conditionally can be considered
> suboptimal rework __zpci_event_error() to get rid of this.
>=20
> Signed-off-by: Heiko Carstens <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260803142907.1771=
[email protected]?part=3D1