Re: [PATCH v2 1/1] s390/ap: Fix MAPML computation
| Newsgroups | org.kernel.vger.linux-s390 |
|---|---|
| Message-ID | <[email protected]> |
> When the TAPQ subfunction of PQAP returns a value between 0 and 3 in the > ml field, the Principles of Operation states that the Maximum AP Message > Length (MAPML) must be 12 KB. > > The previous code incorrectly calculated smaller sizes for ml values 1-2: > - ml=1: 4 KB instead of 12 KB > - ml=2: 8 KB instead of 12 KB > > While no current hardware reports ml=1 or ml=2, this fix ensures correct > behavior for specification compliance and future-proofing. > > The fix ensures all ml values 0-3 correctly use the 12 KB default, with > only values 4+ using the formula ml * 4096. > > Reviewed-by: Harald Freudenberger <[email protected]> > Signed-off-by: Finn Callies <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1