Re: [PATCH net-next 0/2] drivers/s390/net: Enable CONTEXT_ANALYSIS
Alexandra Winter <[email protected]>
| Newsgroups | org.kernel.vger.linux-s390,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 05.08.26 16:50, Heiko Carstens wrote:
> Enable CONTEXT_ANALYSYS for drivers/s390/net.
>
> Static code checking for acquiring and releasing locks used to be done
> with sparse. That was removed with [1] and replaced with a clang based
> approach [2]. The new approach requires that each subsystem needs to be
> explicitly enabled for checking.
>
> Do that for drivers/s390/net. In order to avoid false positives due to
> conditional locking, disable context analysis for specific functions of
> the ctcm driver. All comments in ctcm indicate that the code should stay
> as it is, and that such warnings should be ignored.
>
> Disabling context analysis for specific functions keeps analysis enabled
> for the rest of a file.
>
> [1] 5b63d0ae94cc ("compiler-context-analysis: Remove Sparse support")
> [2] 3269701cb256 ("compiler-context-analysis: Add infrastructure for Context Analysis with Clang")
>
> Heiko Carstens (2):
> s390/ctcm: Add __context_unsafe() attribute to various functions
> drivers/s390/net: Enable CONTEXT_ANALYSIS
>
> drivers/s390/net/Makefile | 2 ++
> drivers/s390/net/ctcm_fsms.c | 20 +++++++-------------
> drivers/s390/net/ctcm_mpc.c | 6 ++----
> 3 files changed, 11 insertions(+), 17 deletions(-)
>
Acked-by: Alexandra Winter <[email protected]>