Re: [PATCH v1] s390/ap: Drop unused member from ap_device_id

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The commit message incorrectly references `device_info` instead of `driver_info`.
- [Low] The `kernel_ulong_t` typedef is no longer used after the removal of `driver_info`.
--

--- Patch [1]: [PATCH v1] s390/ap: Drop unused member from ap_device_id ---
commit 88f5caa72995cfeb3eb825fd5c1c4f333ad8e5d7
Author: Uwe Kleine-König (The Capable Hub) <[email protected]>

s390/ap: Drop unused member from ap_device_id

This commit removes the driver_info member from the ap_device_id structure.
The structure is not part of the API/ABI and the member has no in-kernel
users.

> ap_device_id::device_info is not used in the kernel. The structure is
> also not part of API/ABI, so the unused member can just be dropped.

[Severity: Medium]
This isn't a bug in the code, but the commit message references device_info.
The struct member actually being removed by this patch is named driver_info.

> diff --git a/include/linux/device-id/ap.h b/include/linux/device-id/ap.h
> index 0992333a34db2..011af33c0bcf2 100644
> --- a/include/linux/device-id/ap.h
> +++ b/include/linux/device-id/ap.h
> @@ -14,7 +14,6 @@ typedef unsigned long kernel_ulong_t;

[Severity: Low]
Does this change leave behind an unused typedef?

With the removal of driver_info, it appears the kernel_ulong_t typedef and
its enclosing #ifdef __KERNEL__ block are no longer used anywhere in this
header file.

>  struct ap_device_id {
>  	__u16 match_flags;	/* which fields to match against */
>  	__u8 dev_type;		/* device type */
> -	kernel_ulong_t driver_info;
>  };
>  
>  #endif /* ifndef LINUX_DEVICE_ID_AP_H */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1