Re: [PATCH 2/6] KVM: s390: vsie: Remove duplicate assertion

On Fri, 07 Aug 2026 11:57:43 +0200
Christoph Schlameuss <[email protected]> wrote:

Add this above:

"Remove useless BUILD_BUG_ON() checking the size of struct vsie_page."

and then this:

> This is covered by a static_assert at the struct vsie_page definition.
        ^^^
I would add "already" in there

> 
> Fixes: e38c884df921 ("KVM: s390: Switch to new gmap")
> Signed-off-by: Christoph Schlameuss <[email protected]>
> ---
>  arch/s390/kvm/vsie.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
> index eea24562e7db..3e956c7faa4b 100644
> --- a/arch/s390/kvm/vsie.c
> +++ b/arch/s390/kvm/vsie.c
> @@ -1565,7 +1565,6 @@ int kvm_s390_handle_vsie(struct kvm_vcpu *vcpu)
>  	if (vcpu->arch.sie_block->gpsw.mask & PSW_MASK_PSTATE)
>  		return kvm_s390_inject_program_int(vcpu, PGM_PRIVILEGED_OP);
>  
> -	BUILD_BUG_ON(sizeof(struct vsie_page) != PAGE_SIZE);
>  	scb_addr = kvm_s390_get_base_disp_s(vcpu, NULL);
>  
>  	/* 512 byte alignment */
>