Re: [PATCH 1/6] KVM: s390: Remove double 64bscao feature check

On Fri, 07 Aug 2026 11:57:42 +0200
Christoph Schlameuss <[email protected]> wrote:

> sclp.has_64bscao is already verified in the guard clause a few lines
> above this. So we cannot reach this code if it is not true.
> 
> Reviewed-by: Hendrik Brueckner <[email protected]>
> Reviewed-by: Eric Farman <[email protected]>
> Reviewed-by: Janosch Frank <[email protected]>
> Signed-off-by: Christoph Schlameuss <[email protected]>

Reviewed-by: Claudio Imbrenda <[email protected]>

> ---
>  arch/s390/kvm/kvm-s390.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 150b5dd2170e..c679d8f83c0e 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -455,8 +455,7 @@ static void __init kvm_s390_cpu_feat_init(void)
>  	    !test_facility(3) || !nested)
>  		return;
>  	allow_cpu_feat(KVM_S390_VM_CPU_FEAT_SIEF2);
> -	if (sclp.has_64bscao)
> -		allow_cpu_feat(KVM_S390_VM_CPU_FEAT_64BSCAO);
> +	allow_cpu_feat(KVM_S390_VM_CPU_FEAT_64BSCAO);
>  	if (sclp.has_siif)
>  		allow_cpu_feat(KVM_S390_VM_CPU_FEAT_SIIF);
>  	if (sclp.has_gpere)
>