Re: [PATCH v3 3/3] s390/crypto: Rewrite AES ctr mode to be prepared for context analysis

> The AES ctr implementation produces a warning when used with clang and
> CONTEXT_ANALYIS enabled:
> 
> arch/s390/crypto/aes_s390.c:585:13: warning: mutex 'ctrblk_lock' is not held on every path through here [-Wthread-safety-analysis]
>   585 |                 ctrptr = (n > AES_BLOCK_SIZE) ? ctrblk : walk.iv;
>       |                           ^
> arch/s390/crypto/aes_s390.c:577:11: note: mutex acquired here
>   577 |         locked = mutex_trylock(&ctrblk_lock);
>       |                  ^
> 
> Rewrite and reorganize the code such that the clang compiler's needs
> are fulfilled with keeping the compatibility, performance and
> correctness of the crypto algorithm.
> 
> Signed-off-by: Harald Freudenberger <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3