Re: [PATCH v5 06/13] sparc: Use the common syscall table

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing Makefile dependency on syscall_common.tbl causes stale builds.
--

--- Patch [6]: [PATCH v5 06/13] sparc: Use the common syscall table ---
commit 3c949c999a9aab298b7fdff67ab7b414943dbcad
Author: André Almeida <[email protected]>

sparc: Use the common syscall table

This commit updates the sparc architecture to use the common syscall number
table to remove duplicated code. It modifies the Makefile to pass the common
table to the syscall generation scripts.

> diff --git a/arch/sparc/kernel/syscalls/Makefile b/arch/sparc/kernel/syscalls/Makefile
> index 8440c16dfb225..c6d6378f7aefc 100644
> --- a/arch/sparc/kernel/syscalls/Makefile
> +++ b/arch/sparc/kernel/syscalls/Makefile
[ ... ]
>  quiet_cmd_syshdr = SYSHDR  $@
> -      cmd_syshdr = $(CONFIG_SHELL) $(syshdr) --emit-nr --abis common,$* $< $@
> +      cmd_syshdr = $(CONFIG_SHELL) $(syshdr) --emit-nr --abis $(abis),$* \
> +		   --common-tbl $(syscalltbl_common) $< $@
>  
>  quiet_cmd_systbl = SYSTBL  $@
> -      cmd_systbl = $(CONFIG_SHELL) $(systbl) --abis common,$* $< $@
> +      cmd_systbl = $(CONFIG_SHELL) $(systbl) --abis $(abis),$* \
> +		   --common-tbl $(syscalltbl_common) $< $@
>  
>  $(uapi)/unistd_%.h: $(syscall) $(syshdr) FORCE
>  	$(call if_changed,syshdr)

[Severity: Low]
Does this generation target need $(syscalltbl_common) added to its
prerequisite list?

Since the syshdr and systbl scripts now read from $(syscalltbl_common), not
including it as a prerequisite means the sparc syscall headers might not be
rebuilt during an incremental build when scripts/syscall_common.tbl is updated.
The if_changed macro relies on explicit prerequisites to populate $? and
detect changed input files.

Would it make sense to add it here, and also for the $(kapi)/syscall_table_%.h
target just below it?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6