[PATCH net 0/2] net/iucv: give afiucv_hs_rcv() the preamble a packet_type handler needs
Bryam Vargas via B4 Relay <[email protected]>
| Newsgroups | org.kernel.vger.linux-s390,org.kernel.feeds.b4-sent,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
iucv_packet_type is registered with no .dev and no .af_packet_net, so
afiucv_hs_rcv() sits in the machine-global ptype_base[] and sees every frame of
its ethertype from every namespace, on any device. It then trusts the frame: no
namespace test, and no private or writable reference before it rewrites the
payload in place.
1/2 drop frames from other namespaces -- the only one that crosses a
privilege boundary, and the only one tagged for stable
2/2 unshare and cow the head before the in-place rewrite
The two siblings differ in how far they go, so I will not claim more than they
do: net/x25/x25_dev.c does the namespace test and then takes a full skb_copy()
of every frame, and net/ieee802154/socket.c does the namespace test but does not
unshare at all. 2/2 takes the cheaper of the two -- skb_share_check() plus
skb_cow_head() -- which costs a refcount test and a compare when the frame is
already private, and copies only when it is not.
2/2 also covers the headroom that afiucv_swap_src_dest() pushes without
checking. That started as a third patch; it collapsed into this one once it was
clear skb_cow_head() is needed for writability anyway and asking it for ETH_HLEN
rather than nothing is free.
2/2 was surfaced by the sashiko.dev review bot on the thread of a previous af_iucv
patch, which flagged both the missing unshare and the unchecked push; the Closes:
trailer on that patch points at its report.
By inspection; not reproduced. Compile-tested for s390x.
---
Bryam Vargas (2):
net/iucv: drop HiperSockets frames from other network namespaces
net/iucv: take a private, writable frame before rewriting it in place
net/iucv/af_iucv.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
---
base-commit: a59f57e2aa127c5354168d2ec4bac920df1be4f4
change-id: 20260815-b4-disp-dc82fde4-3cae5e52ae9f
Best regards,
--
Bryam Vargas <[email protected]>