Re: [PATCH v2 2/2] init/Kconfig: make config INIT_ENV_ARG_LIMIT user-configurable
| Newsgroups | org.kernel.vger.linux-s390 |
|---|---|
| Message-ID | <[email protected]> |
> INIT_ENV_ARG_LIMIT is defined without a prompt string (`int`), making it
> a hidden Kconfig symbol that defaults to 32 (or 128 for UML) and cannot
> be configured in `make menuconfig`.
>
> Now that CONFIG_COMMAND_LINE_SIZE is configurable across all architectures,
> users who select larger kernel command lines (e.g., 4096 bytes) may pass
> more than 32 command-line arguments or environment variables (`foo=bar`) to
> `/sbin/init`. If INIT_ENV_ARG_LIMIT remains hardcoded at 32, any argument
> after the 32nd sets the panic_later flag and causes a hard kernel panic
> on boot.
>
> Add a prompt string ("Maximum number of kernel command line arguments") and
> a `range 32 4096` to `config INIT_ENV_ARG_LIMIT` so that users can
> configure their init argument and environment variable limit when needed,
> while preserving the existing default of 32 for standard builds.
>
> Signed-off-by: Maciej Żenczykowski <[email protected]>
> Signed-off-by: Wilson Felipe Pereira <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2