[PATCH v2 1/2] s390/pci: Fix missing pci_dev_put() in zpci_report_status()
Niklas Schnelle <[email protected]>
| Newsgroups | org.kernel.vger.linux-s390,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260819-fix_zpci_report_status_pdev_leak-v2-1-da0c4aa7c0ca@linux.ibm.com> |
In zpci_report_status() a reference to the struct pci_dev associated with the struct zpci_dev being reported about is acquired using pci_get_slot(). This reference needs to be dropped with pci_dev_put() but this call is missing thus leaking the reference. On subsequent hot unplug this will cause the struct pci_dev to not be released leaking memory and potentially prevent reattach. Reviewed-by: Matthew Rosato <[email protected]> Cc: [email protected] Fixes: 4ec6054e7321 ("s390/pci: Report PCI error recovery results via SCLP") Reviewed-by: Farhan Ali <[email protected]> Signed-off-by: Niklas Schnelle <[email protected]> --- arch/s390/pci/pci_report.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/s390/pci/pci_report.c b/arch/s390/pci/pci_report.c index 7030f7052926..76b8afc146fe 100644 --- a/arch/s390/pci/pci_report.c +++ b/arch/s390/pci/pci_report.c @@ -151,6 +151,7 @@ int zpci_report_status(struct zpci_dev *zdev, const char *operation, const char else pr_info("Reported PCI device status\n"); + pci_dev_put(pdev); free_page((unsigned long)report); return ret; -- 2.53.0