Re: [PATCH v2 1/2] s390/pci: Fix missing pci_dev_put() in zpci_report_status()

On Wed, Aug 19, 2026 at 11:58:30AM +0200, Niklas Schnelle wrote:
> In zpci_report_status() a reference to the struct pci_dev associated
> with the struct zpci_dev being reported about is acquired using
> pci_get_slot(). This reference needs to be dropped with pci_dev_put()
> but this call is missing thus leaking the reference. On subsequent hot
> unplug this will cause the struct pci_dev to not be released leaking
> memory and potentially prevent reattach.
> 
> Reviewed-by: Matthew Rosato <[email protected]>
> Cc: [email protected]
> Fixes: 4ec6054e7321 ("s390/pci: Report PCI error recovery results via SCLP")
> Reviewed-by: Farhan Ali <[email protected]>
> Signed-off-by: Niklas Schnelle <[email protected]>
> ---
>  arch/s390/pci/pci_report.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/s390/pci/pci_report.c b/arch/s390/pci/pci_report.c
> index 7030f7052926..76b8afc146fe 100644
> --- a/arch/s390/pci/pci_report.c
> +++ b/arch/s390/pci/pci_report.c
> @@ -151,6 +151,7 @@ int zpci_report_status(struct zpci_dev *zdev, const char *operation, const char
>  	else
>  		pr_info("Reported PCI device status\n");
>  
> +	pci_dev_put(pdev);
>  	free_page((unsigned long)report);
>  
>  	return ret;

Looks good to me!


Reviewed-by: Benjamin Block <[email protected]>

-- 
Best Regards, Benjamin Block        /        Linux on IBM Z Kernel Development
IBM Deutschland Research & Development GmbH    /   https://www.ibm.com/privacy
Vors. Aufs.-R.: Wolfgang Wendt         /        Geschäftsführung: David Faller
Sitz der Ges.: Ehningen     /     Registergericht: AmtsG Stuttgart, HRB 243294