Re: [PATCH v1 1/1] s390/zcrypt: Fix uninitialized padding in CRT key structure

On 25.08.26 18:01, Harald Freudenberger wrote:
> The zcrypt_type6_crt_key() function leaves padding bytes uninitialized
> between key components and the modulus in the CCA CRT key token. These
> padding bytes are sent to the crypto card, potentially leaking kernel
> memory contents.
> 
> The initial memset() only zeros fixed structure fields, not the
> flexible array member key_parts[] where the padding resides. While key
> components are properly copied from userspace, the calculated pad_len
> bytes between them remain uninitialized.
> 
> Fix by explicitly zeroing the padding bytes after copying the CRT key
> components.
> 
> Signed-off-by: Harald Freudenberger <[email protected]>
> ---
>   drivers/s390/crypto/zcrypt_cca_key.h | 1 +
>   1 file changed, 1 insertion(+)
> 

[ snip ]

Reviewed-by: Finn Callies <[email protected]>