Re: [PATCH v2] clk/samsung: fix parent clock refcount leak in exynos_clkout_probe
Krzysztof Kozlowski <[email protected]>
| Newsgroups | org.kernel.vger.linux-samsung-soc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-clk,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On 28/06/2026 14:54, WenTao Liang wrote: > of_clk_get_by_name() acquires clock references stored in the local > parents[] array. All error paths correctly release these via the clks_put > label, but the success path returns 0 without releasing the parent > references. The references were only needed to obtain clock names for > registration and are permanently leaked after probe completes. > > Suggested-by: Greg KH <[email protected]> What was suggested by Greg? > Fixes: 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module driver") > Cc: [email protected] > Signed-off-by: WenTao Liang <[email protected]> > --- > Changes in v2: > - Fix patch format based on reviewer feedback So what is happening here with LLM? Best regards, Krzysztof