Re: [PATCH 0/6] tty: serial: propagate errors from uart_ops.pm callback
Praveen Talari <[email protected]>
| Newsgroups | org.kernel.vger.linux-samsung-soc,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-omap,org.kernel.vger.linux-serial |
|---|---|
| Message-ID | <[email protected]> |
Hi Andy On 09-07-2026 15:46, Andy Shevchenko wrote: > On Thu, Jul 09, 2026 at 02:22:17PM +0530, Praveen Talari wrote: >> On 09-07-2026 12:23, Jiri Slaby wrote: >>> On 09. 07. 26, 8:25, Praveen Talari wrote: > ... > >>> OK, now I miss the rationale behind the patchset. Neither there is a >>> possible code path to actually test this? >> The rationale is that qcom_geni_serial_pm() calls >> pm_runtime_resume_and_get() which can fail, but its return value is >> currently discarded because the callback is void. > So, you take the solution from a wrong end. Just get rid of .pm() in your driver. Ok I agree. Now i can control resources via PM runtime APIs from startup(get_sync()) and shutdown(put_sync()) APIs right? Thanks, Praveen Talari > With that, problem solved. Really, this series is a road to even more broken > PM solutions. >