Re: [PATCH v3 1/5] dt-bindings: clock: samsung: Add Exynos9610 CMU bindings

Krzysztof Kozlowski <[email protected]> Fri, 24 Jul 2026 08:14:14 +0200
Newsgroups org.kernel.vger.linux-samsung-soc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On 24/07/2026 08:13, Krzysztof Kozlowski wrote:
> On Wed, Jul 22, 2026 at 11:44:02PM +0300, Alexandru Chimac wrote:
>> This clock management unit has a topmost block (CMU_TOP)
>> that generates top clocks for other blocks, alongside 20
>> other blocks, out of which 11 are currently implemented.
> 
> This feels not properly wrapped.
> 
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
> 
>>
>> Signed-off-by: Alexandru Chimac <[email protected]>
>> ---
>>  .../bindings/clock/samsung,exynos9610-cmu.yaml     | 335 ++++++++++
>>  include/dt-bindings/clock/samsung,exynos9610-cmu.h | 722 +++++++++++++++++++++
>>  2 files changed, 1057 insertions(+)
> 
> ...

And since I expect new version:

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

Best regards,
Krzysztof