Re: [PATCH] pinctrl: samsung: exynos: replace irq_of_parse_and_map with modern APIs

Krzysztof Kozlowski <[email protected]> Tue, 28 Jul 2026 08:05:34 +0200

Newsgroups	org.kernel.vger.linux-samsung-soc,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On 27/07/2026 21:48, Rosen Penev wrote:
> Replace irq_of_parse_and_map() with fwnode_irq_get() for per-pin IRQ
> lookup and of_irq_get() for the muxed EINT IRQ. The fwnode-based API
> works with both OF and ACPI fwnodes and follows modern conventions.

And what is the point of ACPI here? I see no point in such conversions
of one call while leading everything untouched. Add proper ACPI support
with valid ACPI tables with ENTIRE driver converted, not one call.

> 
> For the muxed EINT path, change the error handling to propagate the
> error code rather than silently returning 0.

But why?

Best regards,
Krzysztof