RE: [PATCH 04/13] arm64: dts: exynos8855: add cmu_top & cmu_peric clock DT nodes

Hi Krzysztof

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk=40kernel.org>
> Sent: Tuesday, July 28, 2026 5:55 PM
> To: Alim Akhtar <alim.akhtar=40samsung.com>; 'raghav.s'
> <raghav.s=40samsung.com>; s.nawrocki=40samsung.com;
> cw00.choi=40samsung.com; peter.griffin=40linaro.org;
> mturquette=40baylibre.com; sboyd=40kernel.org; bmasney=40redhat.com;
> robh=40kernel.org; conor+dt=40kernel.org
> Cc: linux-samsung-soc=40vger.kernel.org; linux-clk=40vger.kernel.org;
> devicetree=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; lin=
ux-
> kernel=40vger.kernel.org; hajun.sung=40samsung.com;
> is.gandhi=40samsung.com; ts.amit=40samsung.com;
> pokala.reddy=40samsung.com
> Subject: Re: =5BPATCH 04/13=5D arm64: dts: exynos8855: add cmu_top &
> cmu_peric clock DT nodes
>=20
> On 28/07/2026 14:23, Alim Akhtar wrote:
> > Hi Krzysztof,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk=40kernel.org>
> >> Sent: Tuesday, July 28, 2026 5:30 PM
> >> To: raghav.s <raghav.s=40samsung.com>; s.nawrocki=40samsung.com;
> >> cw00.choi=40samsung.com; peter.griffin=40linaro.org;
> >> alim.akhtar=40samsung.com; mturquette=40baylibre.com;
> sboyd=40kernel.org;
> >> bmasney=40redhat.com; robh=40kernel.org; conor+dt=40kernel.org
> >> Cc: linux-samsung-soc=40vger.kernel.org; linux-clk=40vger.kernel.org;
> >> devicetree=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org;
> >> linux- kernel=40vger.kernel.org; hajun.sung=40samsung.com;
> >> is.gandhi=40samsung.com; ts.amit=40samsung.com;
> pokala.reddy=40samsung.com
> >> Subject: Re: =5BPATCH 04/13=5D arm64: dts: exynos8855: add cmu_top &
> >> cmu_peric clock DT nodes
> >>
> >> On 28/07/2026 14:11, raghav.s wrote:
> >>> Add required dt node for cmu_top & cmu_peric block
> >>>
> >>> Signed-off-by: raghav.s <raghav.s=40samsung.com>
> >>> ---
> >>>  arch/arm64/boot/dts/exynos/exynos8855.dtsi =7C 24
> >>> ++++++++++++++++++++++
> >>>  1 file changed, 24 insertions(+)
> >>
> >> Please organize your patches in reasonable order. DTS is never in the
> >> middle, see submitting patches (both documents) and maintainer-soc
> profile.
> >>
> > The thought was to add clks block wise and hence we see DTS coming in
> between but for the other blocks.
> > e.g. patch-2 and 3 adds binding and driver for TOP and PERIC and this p=
atch-
> 4 adds DTS.
> > And patch-5 and 6 adds binding and driver for PERIS and patch-7 adds DT=
S
> and so on.
> >
> > Cover-letter should have explained this.
> >
> > Are you suggesting to re-order all the binding first followed by all bl=
ocks
> driver and then add a single DTS for all clock controller?
> >
> > Does current approach helps in review?
>=20
> If you ask this, you did not read the docs.
>=20
I think I just explain the reason why DTS came in-between for each block.
Probably this series should have been sent in multiple chunks, if not, then=
 as you pointed and docs says DTS to be placed at the end of driver changes=
. Agreed.=20
=20
> Best regards,
> Krzysztof