Re:
Sam Protsenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-samsung-soc |
|---|---|
| Message-ID | <CAPLW+4kQTUX8QhKnAP7bg=iCw5hhNQZoW7cuOpTdvvAUpGaicg@mail.gmail.com> |
Hi Thomas, On Wed, Aug 19, 2026 at 8:07 AM [email protected] <[email protected]> wrote: > > From 20f8cda9f788a2d19689f350bff3754ff3c24e3d Mon Sep 17 00:00:00 2001 > From: Thomas Turner <[email protected]> > Date: Wed, 19 Aug 2026 13:48:24 +0100 > Subject: [PATCH] arm64: dts: exynos850: Add GPU/Mali Bifrost node > The actual mail lacks the subject. Did you use "git send-email" or "b4" to submit this patch? > This can provide basic GPU functionality for the Exynos850 platform. > Can you please tell us a bit about how you tested this patch, and on which board? As DPU is not currently enabled on Exynos850 SoC, I'm not sure how exactly GPU can be useful. If you have a use case or a testing procedure we can run on the E850-96 board, please share. Would be nice to have a more detailed commit message overall. In addition to the above, it probably makes sense to also discuss current limitations. E.g. thermal, PD, and DVFS, which are enabled in the downstream kernel's GPU node [1]. Thanks! [1] https://gitlab.com/Linaro/96boards/e850-96/kernel/-/blob/android-exynos-4.14-linaro/arch/arm64/boot/dts/exynos/exynos3830.dts?ref_type=heads#L719 > Signed-off-by: Thomas Turner <[email protected]> > --- > arch/arm64/boot/dts/exynos/exynos850.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi > index 3881f573ec08..8ed85c125030 100644 > --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi > @@ -296,6 +296,18 @@ cmu_g3d: clock-controller@11400000 { > clock-names = "oscclk", "dout_g3d_switch"; > }; > > + gpu: gpu@11500000 { > + compatible = "samsung,exynos850-mali", "arm,mali-bifrost"; > + reg = <0x11500000 0x5000>; > + interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "job", "mmu", "gpu"; > + clocks = <&cmu_g3d CLK_GOUT_G3D_GPU_CLK>; > + clock-names = "core"; > + status = "disabled"; > + }; > + > cmu_apm: clock-controller@11800000 { > compatible = "samsung,exynos850-cmu-apm"; > reg = <0x11800000 0x8000>; > -- > 2.47.3 >