Re: [PATCH 02/45] clk: at91: Make sure clk_init_data is fully initialized
Nicolas Ferre <[email protected]>
| Newsgroups | org.kernel.vger.linux-samsung-soc,dev.linux.lists.imx,dev.linux.lists.linux-sunxi,dev.linux.lists.soc,org.infradead.lists.linux-mediatek,org.kernel.vger.arm-scmi,org.kernel.vger.linux-clk,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-tegra,org.ozlabs.lists.linux-aspeed,org.ozlabs.lists.openbmc |
|---|---|
| Organization | microchip |
| Message-ID | <[email protected]> |
On 21/08/2026 at 10:53, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Make sure all members are fully initialized, to avoid such bugs, and to > prevent future breakage when converting drivers to a different method > for specifying the parents. > > Signed-off-by: Geert Uytterhoeven <[email protected]> > --- > Compile-tested only. > --- > drivers/clk/at91/clk-audio-pll.c | 4 ++-- > drivers/clk/at91/clk-h32mx.c | 2 +- > drivers/clk/at91/clk-main.c | 2 +- > drivers/clk/at91/clk-pll.c | 2 +- > drivers/clk/at91/clk-plldiv.c | 2 +- > drivers/clk/at91/clk-slow.c | 2 +- > drivers/clk/at91/clk-smd.c | 2 +- > drivers/clk/at91/clk-usb.c | 6 +++--- > drivers/clk/at91/sckc.c | 2 +- > 9 files changed, 12 insertions(+), 12 deletions(-) Acked-by: Nicolas Ferre <[email protected]> Thanks Geert, Nicolas