Re: [PATCH 00/45] clk: Make sure clk_init_data is fully initialized (part two)

Am Dienstag, 25. August 2026, 17:11:47 Mitteleuropäische Sommerzeit schrieb Brian Masney:
> Hi Heiko,
> 
> On Mon, Aug 24, 2026 at 11:11:32PM +0200, Heiko Stübner wrote:
> > Am Freitag, 21. August 2026, 10:53:10 Mitteleuropäische Sommerzeit schrieb Geert Uytterhoeven:
> > > 	Hi all,
> > > 
> > > The clk_init_data structure contains several mutually-exclusive members
> > > for different methods to specify the possible parents of a clock,
> > > prompting drivers to initialize only the members they need.  However,
> > > not initializing all members may cause subtle issues, which are only
> > > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
> > > enabled.
> > > 
> > > Hence this series aims to make sure all members are fully initialized,
> > > to avoid such bugs, and to prevent future breakage when converting
> > > drivers to a different method for specifying the parents.
> > > 
> > > Part One[1] fixed all cases that I identified to be real bugs, in
> > > response to a crash I saw on BeagleBone Black.
> > > 
> > > This series is the clock subpart of Part Two, which fixes remaining
> > > cases that are currently harmless.  These are still fragile, and may
> > > cause future breakage when converting drivers to a different method for
> > > specifying the parents.
> > > 
> > > Thanks for your comments!
> > 
> > I guess more a handling question, how do you expect this series to be
> > applied?
> > 
> > I.e. each clk-arch-maintainer, or in one big thing by the core clock
> > maintainers? Just wondering if I should pick the Rockchip patch
> > or just let the whole series get applied by the clock maintainers.
> 
> Before you pick up anything, let's see if Stephen picks up this series
> the next few days before he sends his pull to Linus.
> 
> Next development cycle, Jerome Brunet and I will be clk co-maintainers
> [1] and will start collecting patches then. If Stephen doesn't pick up
> this whole series this week, then pick up the patch(es) relevant for
> your tree and send Jerome and I pull as usual. That's just in case
> there's other patches that come in during the next development cycle to
> these files and to avoid merge conflicts. I don't have a strong opinion
> about this though, and could be convinced to take the whole series for
> simplicity.

Thanks for the heads up on the maintainer expansion :-) .

At least for me both work - Geert's fixes are for the clock types used
by the Rockchip clock drivers and generally we mostly get new clock trees,
so there shouldn't be any conflicts between this and other new stuff ;-) .


Heiko


> [1] https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=8bc7ceadce1f362a8b0e88075ef3d926b286c01c
> 
> Brian
> 
>