Re: [PATCH v4 9/9] PCI: Fix UAF when probe runs concurrent to dyn ID removal
| Newsgroups | org.kernel.vger.linux-scsi,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-ide,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> Dynamic IDs are only guaranteed to be valid when dynids.lock is held, > as remove_id_store() can free the node. Thus, make a copy in > pci_match_device(). Also, clarify that the id parameter is only valid > during probe. > > Reported-by: Sashiko <[email protected]> > Link: https://lore.kernel.org/all/[email protected]/ > Fixes: 0994375e9614 ("PCI: add remove_id sysfs entry") > Reviewed-by: Danilo Krummrich <[email protected]> > Signed-off-by: Gary Guo <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=9