Re: [PATCH v2 1/3] scsi: ufs: spacemit: dt-bindings: Add UFS controller for K3 SoC

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The DT binding example incorrectly formats the deprecated `freq-table-hz` property as a flat array, causing a schema validation failure.
- [Low] The `compatible` property is omitted from the `required` list in the binding schema.
--

--- Patch [1]: [PATCH v2 1/3] scsi: ufs: spacemit: dt-bindings: Add UFS controller for K3 SoC ---
commit b7ba054d14f9257aed59f8435e45924091cd034f
Author: Yixun Lan <[email protected]>

scsi: ufs: spacemit: dt-bindings: Add UFS controller for K3 SoC

This commit documents the device tree bindings for the UFS (Universal Flash
Storage) Host Controller found on the SpacemiT K3 SoC.

> diff --git a/Documentation/devicetree/bindings/ufs/spacemit,k3-ufshc.yaml b/Documentation/devicetree/bindings/ufs/spacemit,k3-ufshc.yaml
> new file mode 100644
> index 0000000000000..45cd7837c3f76
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ufs/spacemit,k3-ufshc.yaml

[ ... ]

> +required:
> +  - reg
> +  - clocks
> +  - clock-names
> +  - resets

[Severity: Low]
Is the compatible property missing from this list? Standard schema guidelines
generally require leaf device bindings to explicitly include compatible in
their required array to properly enforce its presence during node validation.

> +
> +allOf:
> +  - $ref: ufs-common.yaml

[ ... ]

> +    ufs@c0e00000 {
> +        compatible = "spacemit,k3-ufshc";
> +        reg = <0xc0e00000 0x40000>;
> +        clocks = <&syscon_apmu CLK_APMU_UFS_ACLK>,
> +        <&syscon_apmu CLK_APMU_UFS_REFCLK>;
> +        clock-names = "aclk", "ref_clk";
> +        resets = <&syscon_apmu RESET_APMU_UFS_ACLK>;
> +        interrupts = <135 IRQ_TYPE_LEVEL_HIGH>;
> +        freq-table-hz = <491520000 491520000 19200000 19200000>;

[Severity: Low]
Will this fail schema validation?

The ufs-common.yaml schema defines freq-table-hz as an array of arrays, so
this flat array might need to be formatted as tuples, for example:
<491520000 491520000>, <19200000 19200000>;

Also, freq-table-hz is explicitly marked as deprecated in the common schema
and replaced by operating-points-v2. Does this new binding need to use a
deprecated property in its example?

> +        lanes-per-direction = <2>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1