Re: [PATCH] Revert "scsi: ufs: core: Remove unnecessary block I/O quiesce for clock scaling"
David Heidelberg <[email protected]>
| Newsgroups | org.kernel.vger.linux-scsi,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 23/07/2026 14:47, Manivannan Sadhasivam wrote: > This reverts commit 85b2b966285498e1b551ac85f02c79cd06c0cff0. > > Qcom UFS Host Controllers do not support scaling clocks when the traffic is > ongoing. But the offending commit removed the block I/O quiesce in the > clock scaling path, which causes below UFS failures during clock scaling: > > ufshcd-qcom 1d84000.ufshc: ufshcd_check_errors: saved_err 0x80 saved_uic_err 0x0 > ufshcd-qcom 1d84000.ufshc: ufshcd_err_handler started; HBA state eh_fatal; powered 1; shutting down 0; saved_err = 0x80; saved_uic_err = 0x0; force_reset = 0 > ufshcd-qcom 1d84000.ufshc: pwr ctrl cmd 0x2 with (MIBattribute 0x1571, mode 0x11) completion timeout > ufshcd-qcom 1d84000.ufshc: UFS Host state=3 > ufshcd-qcom 1d84000.ufshc: 7 outstanding reqs, tasks=0x0 > ufshcd-qcom 1d84000.ufshc: saved_err=0x80, saved_uic_err=0x0 > ufshcd-qcom 1d84000.ufshc: Device power mode=1, UIC link state=1 > ufshcd-qcom 1d84000.ufshc: PM in progress=0, sys. suspended=0 > ufshcd-qcom 1d84000.ufshc: Auto BKOPS=0, Host self-block=0 > ufshcd-qcom 1d84000.ufshc: Clk gate=1 > ufshcd-qcom 1d84000.ufshc: last_hibern8_exit_tstamp at 196451913 us, hibern8_exit_cnt=20 > ufshcd-qcom 1d84000.ufshc: error handling flags=0x0, req. abort count=0 > ufshcd-qcom 1d84000.ufshc: hba->ufs_version=0x300, Host capabilities=0x1587031f, caps=0x124f > ufshcd-qcom 1d84000.ufshc: quirks=0x0, dev. quirks=0x310c4 > ufshcd-qcom 1d84000.ufshc: UFS dev info: SAMSUNG KLUDG4UHDB-B2D1 rev 0400 > ufshcd-qcom 1d84000.ufshc: clk: core_clk, rate: 300000000 > ufshcd-qcom 1d84000.ufshc: clk: core_clk_unipro, rate: 300000000 > > Hence, revert the commit to bring back UFS on all Qcom platforms. > > Reported-by: Shawn Guo <[email protected]> > Closes: https://lore.kernel.org/linux-scsi/al8YkXydXJQZrl_Y@QCOM-aGQu4IUr3Y > Signed-off-by: Manivannan Sadhasivam <[email protected]> > --- > drivers/ufs/core/ufshcd.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Tested-by: David Heidelberg <[email protected]> # sdm845 (Pixel 3, multiple phones)