Re: [PATCH v2 2/3] zfcp: Trace plogi and prli within open port response as payload

> From: Steffen Maier <[email protected]>
> 
> The FCP channel optionally returns the content of PLOGI and PRLI within
> open port response. This information is needed to debug unexpected open
> port responses. Pack both PLOGI and PRLI information back-to-back into a
> PAYload trace record of type "fsf_els" within existing HBA trace record.
> 
> The length of both parts, and thus also the offset of the second part,
> are added to the corresponding HBA trace record. Be extra careful
> regarding bounds checking.
> 
> Since auto port scan in multi-initiator zoning environments can cause a
> lot of failed open port responses and trace is enabled by default in the
> HBA trace area, chose a trace level 4 above the default of 3 for the
> corresponding PAYload trace record to contain PLOGI/PRLI data. This way,
> [ ... ]
> Reviewed-by: M Nikhil <[email protected]>
> Reviewed-by: Nihar Panda <[email protected]>
> Signed-off-by: Steffen Maier <[email protected]>
> Co-developed-by: Chinmaya Kajagar <[email protected]>
> Signed-off-by: Chinmaya Kajagar <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2