Re: [PATCH 1/3] scsi: lpfc: Fix race conditions in ELS retry handling

Hello Kyle,

Sorry for the long delay.

I think the routine lpfc_cancel_retry_delay_tmo needs to do the
test_and_clear_bit op first and without a lock.  The Linux BitOps guarantee
atomicity.

Then the timer_delete_sync needs to run next.  This two operations are
the primary
purpose of the routine and try to close the window with a schedule
retry delay timer.

I think the hbalock around the evtp->evt_listp is correct.  The
evtp_listp is a phba->worklist
controlled element so the coarse grain hbalock is required.

The rest of the patch looks good.

I'll post my version to the bug we are using to track this issue.

Thanks

Paul

On Mon, Jul 13, 2026 at 12:26 PM Kyle Mahlkuch <[email protected]> wrote:
>
> On 6/18/26 8:39 AM, Paul Ely wrote:
> > Hello Daniel,
> >
> > I have been testing Patch 1 of 3 for a while now but no reproduction.  I
> > reviewed Patch 1 of 3 yesterday with Justin and we think it needs some
> > minor rework.
>
> Hi Paul,
> If you have a reworked patch I'd be happy to test it.
>
> Thanks,
> Kyle