Re: [PATCH] scsi: core: do not block on tag allocation in scsi_eh_lock_door()

Bart Van Assche <[email protected]> Thu, 30 Jul 2026 11:12:00 -0700
Newsgroups org.kernel.vger.linux-scsi,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On 7/22/26 9:12 PM, Zizhi Wo wrote:
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index 147127fb4db9..3d42fe7701b7 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -2139,11 +2139,11 @@ static enum rq_end_io_ret eh_lock_door_done(struct request *req,
>   static void scsi_eh_lock_door(struct scsi_device *sdev)
>   {
>   	struct scsi_cmnd *scmd;
>   	struct request *req;
>   
> -	req = scsi_alloc_request(sdev->request_queue, REQ_OP_DRV_IN, 0);
> +	req = scsi_alloc_request(sdev->request_queue, REQ_OP_DRV_IN, BLK_MQ_REQ_NOWAIT);
>   	if (IS_ERR(req))
>   		return;
>   	scmd = blk_mq_rq_to_pdu(req);
>   
>   	scmd->cmnd[0] = ALLOW_MEDIUM_REMOVAL;

Reviewed-by: Bart Van Assche <[email protected]>