[PATCH v3 28/57] scsi: hpsa: Prepare for enabling lock context analysis
Bart Van Assche <[email protected]> Thu, 30 Jul 2026 15:45:11 -0700
| Newsgroups | org.kernel.vger.linux-scsi |
|---|---|
| Message-ID | <e26d3c5bd77310a14adb0d72e9f1b5f760a4a4a4.1785451174.git.bvanassche@acm.org> |
mutex_lock_interruptible() returns a negative value upon failure or zero upon success. Since the Clang thread-safety analyzer only supports == 0 and != 0 tests for functions that perform conditional locking, change the == -EINTR test into != 0. This change does not modify the behavior of hpsa_do_reset(). Signed-off-by: Bart Van Assche <[email protected]> --- drivers/scsi/hpsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index a1b116cd4723..1b3595c6e036 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -3163,7 +3163,7 @@ static int hpsa_do_reset(struct ctlr_info *h, struct hpsa_scsi_dev_t *dev, int rc = 0; /* We can really only handle one reset at a time */ - if (mutex_lock_interruptible(&h->reset_mutex) == -EINTR) { + if (mutex_lock_interruptible(&h->reset_mutex)) { dev_warn(&h->pdev->dev, "concurrent reset wait interrupted.\n"); return -EINTR; }