Re: [PATCH v3 55/57] scsi: core: Pass the SCSI host pointer directly

Thank you for your contribution! Sashiko AI review found 1 potential issue(=
s) to consider:
- [Low] The kernel-doc block for `scsi_report_lun_scan()` was not updated t=
o document the newly added `shost` parameter.
--

--- Patch [55]: [PATCH v3 55/57] scsi: core: Pass the SCSI host pointer dir=
ectly ---
commit 843d3f98c1bc1414a3f6276906221ddaef557d90
Author: Bart Van Assche <[email protected]>

scsi: core: Pass the SCSI host pointer directly

In several SCSI scanning functions, the SCSI host pointer is derived from
the SCSI target pointer. This patch updates these functions to pass the
SCSI host pointer directly, preparing for lock context analysis. No
functionality is changed.

> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index e27da038603a2..a8994c07d4154 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c

[ ... ]

> @@ -1438,8 +1440,9 @@ static void scsi_sequential_lun_scan(struct scsi_ta=
rget *starget,
>   *     0: scan completed (or no memory, so further scanning is futile)
>   *     1: could not scan with REPORT LUN
>   **/
> -static int scsi_report_lun_scan(struct scsi_target *starget, blist_flags=
_t bflags,
> -				enum scsi_scan_mode rescan)
> +static int scsi_report_lun_scan(struct Scsi_Host *shost,
> +			struct scsi_target *starget, blist_flags_t bflags,
> +			enum scsi_scan_mode rescan)

[Severity: Low]
Should the kernel-doc block for scsi_report_lun_scan() be updated to include
the new @shost parameter?

It looks like the parameter was added to the function signature, but unlike
scsi_probe_and_add_lun() and scsi_sequential_lun_scan(), the documentation
wasn't updated here.

--=20
Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1785451174.gi=
[email protected]?part=3D55